Agreed, but I’m pretty sure the auto-formatters available do alignment indentation anyway as it is part of the style guides.
Otherwise, I think some of the lines have too much nesting and could be broken up, and the ifcond-then-else blocks aren’t indented enough in the last example.
Or, if the business is 24/7, make sure they have an explicit on-call policy with designated shifts. (e.g. who is allowed to call you, what is the expected response time, is an issue disruptive enough that it needs resolving at 3am on a holiday, etc.)
My current job (IT for a non-profit research facility) pays a sweet daily bonus just for having my phone on me, even if I don’t get called over a week, plus double overtime pay when I do get called afterhours. I’ve had 13 shifts over the past couple years, and was called only 7-8 times, 3 of those on the same weekend for the same issue (couldn’t make a permanent fix until the following Monday).
In any other job, I definitely wouldn’t accept a manager or random coworkers sending me messages out of the blue on a weekend and getting mad when I don’t respond.
Gahh, serves me right for blindly writing code on my phone!
Functions in Python can only return a single value. While you are allowed to comma-separate additional values, as you have done, they are combined into a single tuple object that wraps the intended values.
As such, your splitter function is returning a single tuple containing three strings. Your calculate function is expecting three individual arguments (I’m guessing that the error trace mentions this).
To get around this, you can use the splat/asterisk operator to “unpack” the items from the tuple:
a, b, c = splitter(expression)
# or, inline
calculate(*splitter(expression))
Edit: removed bad asterisk
I use it mainly for code completion, and it’s great until I hit <tab> to indent and accidentally accept a 50 line suggestion.