• ThePuy@feddit.nl
    link
    fedilink
    arrow-up
    17
    ·
    11 months ago

    I think that was the right approach, then again didn’t you have through a pull request or at least a code review? Knowing that would give raise to so many “errors” you should have had some sort of communication beforehand.

    I don’t blame you, more the workflow and ironically the manager

    • lobut@lemmy.ca
      link
      fedilink
      arrow-up
      12
      ·
      11 months ago

      Oh that was like years ago! Probably SVN, we on-boarded Git a little while after.

      No pull requests, you just manually merged back then. It’s definitely a workflow improvement we adopted later and we as a company and as an industry have gotten better.

      lol, the thing was just that my manager asked me what I did and I told him. Him getting another dev to “fact-check” me after is what bothered me a bit. I am usually the type of look into issues rather than brush them off and I am the first to confess to a screw up. Which is why I was irked.